]> Wikimedia Canada | Git repositories - eccc_to_commons.git/commitdiff
Prevent empty files to be generated
authorPierre Choffet <peuc@wanadoo.fr>
Fri, 6 Mar 2020 17:56:14 +0000 (12:56 -0500)
committerPierre Choffet <peuc@wanadoo.fr>
Fri, 6 Mar 2020 17:56:14 +0000 (12:56 -0500)
ECCC sometimes provides almanac files containing no data at all. We won't convert them into JSON file anymore.

eccc_to_commons.sh

index 5381bb5933d8f1bc3903f2ef9ee1134b061f558e..f6d399b67fe8028ca26475d128d15a9c474e90f6 100755 (executable)
@@ -92,6 +92,14 @@ do
        elif [ ${STATIONDATA_COUNT} -eq 0 ]&& \
             [ ${AL_MONTH_COUNT} -gt 0 ]
        then
+               # Check file contains data
+               declare -i AL_DAY_COUNT=$(xmlstarlet sel -t -v 'count(//day)' "${REPLY}")
+               if [ ${AL_DAY_COUNT} -eq 0 ]
+               then
+                       echo "${REPLY}: No day found. Ignoring." >&2
+                       continue
+               fi
+
                STYLESHEET_PATH='almanac_to_commons.xslt'
                DESTINATION_PATH="${DESTINATION}/weather.gc.ca/Almanac/${CLIMATE_ID}.tab"
        else