From: Pierre Choffet <peuc@wanadoo.fr>
Date: Fri, 6 Mar 2020 17:56:14 +0000 (-0500)
Subject: Prevent empty files to be generated
X-Git-Url: https://git.wikimedia.ca/?p=eccc_to_commons.git;a=commitdiff_plain;h=6ff82316880b4664fb2e31c9dd5fc21d919390e5

Prevent empty files to be generated

ECCC sometimes provides almanac files containing no data at all. We won't convert them into JSON file anymore.
---

diff --git a/eccc_to_commons.sh b/eccc_to_commons.sh
index 5381bb5..f6d399b 100755
--- a/eccc_to_commons.sh
+++ b/eccc_to_commons.sh
@@ -92,6 +92,14 @@ do
 	elif [ ${STATIONDATA_COUNT} -eq 0 ]&& \
 	     [ ${AL_MONTH_COUNT} -gt 0 ]
 	then
+		# Check file contains data
+		declare -i AL_DAY_COUNT=$(xmlstarlet sel -t -v 'count(//day)' "${REPLY}")
+		if [ ${AL_DAY_COUNT} -eq 0 ]
+		then
+			echo "${REPLY}: No day found. Ignoring." >&2
+			continue
+		fi
+
 		STYLESHEET_PATH='almanac_to_commons.xslt'
 		DESTINATION_PATH="${DESTINATION}/weather.gc.ca/Almanac/${CLIMATE_ID}.tab"
 	else